Comment utiliser le filtre "http_request_host_is_external"

Question

Comment utiliser le filtre "http_request_host_is_external"

3

8110 2013-11-14

J'ai vraiment dumal à utiliser lefiltre http_request_host_is_external. Pour quelquesinformations,j'essaie de configurer un serveur séparépourgérer lesmises àjourprivées despluginset desthèmes. Leproblèmeest que c'est sur un serveur séparé,donc lafonction Wordpress wp_http_validate_url (wp-includes/http.php)tue la requête. Voici les lignes 481 à 503 de cefichier.

 if ( $ip ) {
        $parts = array_map( 'intval', explode( '.', $ip ) );
        if ( '127.0.0.1' === $ip
            || ( 10 === $parts[0] )
            || ( 172 === $parts[0] && 16 <= $parts[1] && 31 >= $parts[1] )
            || ( 192 === $parts[0] && 168 === $parts[1] )
        ) {
            // If host appears local, reject unless specifically allowed.
            /**
             * Check if HTTP request is external or not.
             *
             * Allows to change and allow external requests for the HTTP request.
             *
             * @since 3.6.0
             *
             * @param bool false Whether HTTP request is external or not.
             * @param string $host IP of the requested host.
             * @param string $url URL of the requested host.
             */
            if ( ! apply_filters( 'http_request_host_is_external', false, $host, $url ) )
                return false;
        }
    }

Vous remarquerez qu'il y a un commentaire là-dedans quimentionne quenous devrions êtreen mesure d'appliquer lefiltreet defaire des demandesexternes,mais ce quej'essaiene semblepasfonctionner.

     require 'plugin_update_checker.php';
apply_filters( 'http_request_host_is_external', true, "my-update-server.com", 'http://my-update-server.com/update/8b6b28f1a2604deea192076cb2343ff4/' );
$MyUpdateChecker = new PluginUpdateChecker_1_3(
    'http://my-update-server/update/8b6b28f1a2604deea192076cb2343ff4/',
    __FILE__,
    'testslug'
);

Jepensais que sije définissais lefiltre dans lefichierprincipal demonplugin,il s'en occuperait,maisje pense que leproblèmeest que la demandeexterne seproduit directement dans leprogramme demise àjour de Wordpress,alorspeut-être quemonfiltrene s'appliquepas?

I'm having a really hard time trying to use the http_request_host_is_external filter. For some background, I'm trying to set up a separate server to handle private plugin and theme updates. The problem is that it's on a separate server, so the Wordpress wp_http_validate_url (wp-includes/http.php) function kills the request. The following are lines 481-503 of that file.

if ( $ip ) {
        $parts = array_map( 'intval', explode( '.', $ip ) );
        if ( '127.0.0.1' === $ip
            || ( 10 === $parts[0] )
            || ( 172 === $parts[0] && 16 <= $parts[1] && 31 >= $parts[1] )
            || ( 192 === $parts[0] && 168 === $parts[1] )
        ) {
            // If host appears local, reject unless specifically allowed.
            /**
             * Check if HTTP request is external or not.
             *
             * Allows to change and allow external requests for the HTTP request.
             *
             * @since 3.6.0
             *
             * @param bool false Whether HTTP request is external or not.
             * @param string $host IP of the requested host.
             * @param string $url URL of the requested host.
             */
            if ( ! apply_filters( 'http_request_host_is_external', false, $host, $url ) )
                return false;
        }
    }

You'll notice that there is a comment in there that mentions we should be able to apply the filter and make external requests, but what I'm trying doesn't seem to work.

    require 'plugin_update_checker.php';
apply_filters( 'http_request_host_is_external', true, "my-update-server.com", 'http://my-update-server.com/update/8b6b28f1a2604deea192076cb2343ff4/' );
$MyUpdateChecker = new PluginUpdateChecker_1_3(
    'http://my-update-server/update/8b6b28f1a2604deea192076cb2343ff4/',
    __FILE__,
    'testslug'
);

I thought that if I set the filter in my plugin's main file it would take care of it, but I think the issue is that the external request is happening right in Wordpress's updater, so maybe my filter doesn't apply?

2 réponses

votes

0

2013-11-14

Je suis apparemment unpeu rouillé.Cela s'est occupé demoi:

 add_filter( 'http_request_host_is_external', function() { return true; });

I'm apparently a little rusty. This took care of it for me:

add_filter( 'http_request_host_is_external', function() { return true; });

Otto · Accepted Answer · 2013-11-14

11

2013-11-14

Vouspouvezfaire ceci:

 add_filter( 'http_request_host_is_external', '__return_true' );

Cependant,notez que cela désactive cettefonction de sécurité.Si vous savez que l'hôte ou l'URLne changerapaset le seratoujours,vouspouvez êtreplus sûren vérifiant celaexplicitement:

 add_filter( 'http_request_host_is_external', 'allow_my_custom_host', 10, 3 );
function allow_my_custom_host( $allow, $host, $url ) {
  if ( $host == 'my-update-server' )
    $allow = true;
  return $allow;
}

You can do this:

add_filter( 'http_request_host_is_external', '__return_true' );

However, note that this disables this security feature. If you know the host or url isn't going to change and is always going to be that, you can be more secure by checking for that explicitly:

add_filter( 'http_request_host_is_external', 'allow_my_custom_host', 10, 3 );
function allow_my_custom_host( $allow, $host, $url ) {
  if ( $host == 'my-update-server' )
    $allow = true;
  return $allow;
}

Quels sont les 3eet 4e argumentspour (,,10,3)?

What are the 3rd and 4th arguments for (,,10,3)?
- 0
- 2013-11-15
- Jack Slingerland
Le 10est lapriorité dufiltre (10est leparamètrepar défaut),et le 3est lenombre d'arguments àpasser à lafonction defiltre (la valeurpar défautest 1).C'estpourquoij'ai dû ajouter les 10,3ici,carje veux que lafonction reçoive les valeurs $ hostet $ url.

The 10 is the priority of the filter (10 is the default setting), and the 3 is the number of arguments to pass to the filter function (the default is 1). This is why I had to add the 10, 3 here, because I want the function to get the $host and $url values passed to it.
- 1
- 2013-11-15
- Otto