Comment renvoyer le nombre de lignes trouvées à partir de la requête SELECT

Question

Comment renvoyer le nombre de lignes trouvées à partir de la requête SELECT

16

83499 2014-01-29

J'ai écrit unefonction quiest censée renvoyer lenombre de lignestrouvées dans une requête SELECTmaiselle sembletoujours renvoyer 0 ou untableau. Celafaitenviron une heure queje déconne avec çaet jen'arrivetoujourspas à comprendre! Je suis sûr queje fais quelque chose de stupidementmal.

Latable MySQL

 +--------+-------------+---------------------+
| postid |     ip      |        time         |
+--------+-------------+---------------------+
|   1234 | 192.168.0.1 | 2014-01-29 14:27:02 |
|   5678 | 192.168.0.2 | 2014-01-29 14:27:02 |
+--------+-------------+---------------------+

PHP

 ### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $wpdb->get_results("SELECT * FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = $ip");

    $rowcount = $wpdb->num_rows;

    return $rowcount;
}

postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

I wrote a function which is supposed to return the number of rows found in a SELECT query but it always either seems to return 0 or an array. I have been messing around with this for about an hour now and I still can't figure it out! I'm sure I'm doing something stupidly wrong.

The MySQL Table

+--------+-------------+---------------------+
| postid |     ip      |        time         |
+--------+-------------+---------------------+
|   1234 | 192.168.0.1 | 2014-01-29 14:27:02 |
|   5678 | 192.168.0.2 | 2014-01-29 14:27:02 |
+--------+-------------+---------------------+

PHP

### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $wpdb->get_results("SELECT * FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = $ip");

    $rowcount = $wpdb->num_rows;

    return $rowcount;
}

postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

- Quelest lenom de latableet lepréfixe de latable?
  
  What is the name of the table and the table prefix?
  - 0
  - 2014-01-29
  - Chittaranjan
- @Chittaranjan Lenom de latableest wp_postviews_ips,je ne suispas sûr de ce que vousentendezparpréfixe detable.
  
  @Chittaranjan Table name is wp_postviews_ips, I'm not sure what you mean by table prefix though.
  - 0
  - 2014-01-29
  - Swen
- Supprimer "$ wpdb->" de $ wpdb-> wp_postviews_ips semblaitfaire l'affaire!
  
  Removing "$wpdb->" from $wpdb->wp_postviews_ips seemed to do the trick!
  - 0
  - 2014-01-29
  - Swen
- C'est la raisonpour laquellej'avais demandé lenomet lepréfixe de latable.Toutes lestables wordpress ont unpréfixe que vous définissez lors de la configuration du site wordpress.Voiciplus de détails sur [codex] (http://codex.wordpress.org/Creating_Tables_with_Plugins#Database_Table_Prefix) Veuillez vérifierma réponsemise àjour avec l'utilisation correcte dunom de latable.
  
  That's the reason I had asked for the table name and prefix. All wordpress tables have a prefix which you set during setting up the wordpress site. Here are more details on [codex](http://codex.wordpress.org/Creating_Tables_with_Plugins#Database_Table_Prefix) Please check my updated answer with correct use of table name.
  - 0
  - 2014-01-29
  - Chittaranjan

2 réponses

votes

- 2
- 2014-01-29
Il semble que la requêteestincorrecte.$ipest une chaîne,vous devez doncmettre unguillemet simple autour de cela comme ci-dessous

$wpdb->get_results("SELECT * FROM {$wpdb->prefix}postviews_ips WHERE postid = $id AND ip = '$ip'");
Seems the query is wrong. $ip is string so you should put single quote around that as below

$wpdb->get_results("SELECT * FROM {$wpdb->prefix}postviews_ips WHERE postid = $id AND ip = '$ip'");
- J'aiessayé celaet il renvoietoujours 0.
  
  Tried this and it still returns 0.
  - 0
  - 2014-01-29
  - Swen

eteich · Accepted Answer · 2014-01-29

29

2014-01-29

Si vousessayez simplement d'obtenir unnombre,$wpdb->get_var(); ainsi que l'utilisation de COUNT() dans votre sql seramieux:

 ### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $rowcount = $wpdb->get_var("SELECT COUNT(*) FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = '$ip'");

    return $rowcount;
}

postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

Quant à ce quin'apasfonctionné dans votreexempleprécédent,vousn'assigniezpas votreinstance $wpdb->get_results() à une variable,et sanselle $wpdb->num_rows; va simplement renvoyer zéro carilne tirepas réellement de l'instance de la requête,maisplutôt de l'objetglobal $ wbdb.

Si vous souhaitez utiliser get_results():

 ### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $ipquery= $wpdb->get_results("SELECT * FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = '$ip'");
    $rowcount = $ipquery->num_rows;
    return $rowcount;
}

postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

Maisje n'en verraispas lebesoin àmoins que vousn'ayezbesoin des résultats,auquel casje retournerais simplement l'objet $ipqueryet utiliserais num_rows dessus quand J'en avaisbesoin:

 ### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $ipquery = $wpdb->get_results("SELECT * FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = '$ip'");
    return $ipquery;
}

$someVariable = postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

echo $someVariable->num_rows;

If you are merely trying to get a count, $wpdb->get_var(); along with using COUNT() in your sql will be better:

### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $rowcount = $wpdb->get_var("SELECT COUNT(*) FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = '$ip'");

    return $rowcount;
}

postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

As to what went wrong in your previous example, you weren't assigning your $wpdb->get_results() instance to a variable, and without it $wpdb->num_rows; is just going to return zero as it isn't actually pulling from the instance of the query, but rather the global $wbdb object.

If you do want to use get_results():

### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $ipquery= $wpdb->get_results("SELECT * FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = '$ip'");
    $rowcount = $ipquery->num_rows;
    return $rowcount;
}

postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

But I wouldn't see the need for that unless you needed the results, in which case I would just return the $ipquery object and use num_rows on it when I needed it:

### Search for IP in database
function postviews_get_ip($id, $ip) {
    global $post, $wpdb;

    $ipquery = $wpdb->get_results("SELECT * FROM $wpdb->wp_postviews_ips WHERE postid = $id AND ip = '$ip'");
    return $ipquery;
}

$someVariable = postviews_get_ip($id, $_SERVER['REMOTE_ADDR']);
//both $id and $_SERVER['REMOTE_ADDR']) return the values I'm searching for in the database

echo $someVariable->num_rows;

Petit ajout.Vous deveztoujours utiliserprepare (https://developer.wordpress.org/reference/classes/wpdb/prepare/) lors de l'exécution de requêtespourempêcher l'injection SQL.

Small addition. You should always use prepare (https://developer.wordpress.org/reference/classes/wpdb/prepare/) when executing any queries to prevent sql injection.
- 1
- 2019-05-29
- Maciej Paprocki
Enfait,celane devraitpas être unpetit ajout,c'esttrèsimportant dene pas rendre votre codeexploitable via uneinjection SQL.

Actually that shouldnt be a small addition, that's very important not to make your code exploitable via sql injection.
- 0
- 2019-09-12
- Max Carroll